fix(tests): remove undeeded broken tests #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test broke due to a regression after the latest on_new_tx refactor. However this test isn't actually adding anything right now. This should be reviewed in #648
jansegre
force-pushed
the
fix/remove-sync-checkpoint-test
branch
from
3ff3e20 to
7ac143f
Compare
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 247 247
Lines 20401 20376 -25
Branches 2757 2748 -9
=======================================
- Hits 17111 17091 -20
+ Misses 2711 2710 -1
+ Partials 579 575 -4
|
msbrogli
approved these changes
Jun 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test broke due to a regression after the latest on_new_tx refactor. However this test isn't actually adding anything right now. This should be reviewed in #648
Acceptance criteria
test_checkpoint_validationshould be removed